On Tue, Feb 11, 2025 at 02:31:14PM +0100, Konrad Dybcio wrote: > On 3.02.2025 7:14 PM, Danila Tikhonov wrote: > > From: Eugene Lepshy <fekz115@xxxxxxxxx> > > > > Enable the Adreno GPU and configure the Visionox RM692E5 panel. > > > > Signed-off-by: Eugene Lepshy <fekz115@xxxxxxxxx> > > Co-developed-by: Danila Tikhonov <danila@xxxxxxxxxxx> > > Signed-off-by: Danila Tikhonov <danila@xxxxxxxxxxx> > > --- > > Note: > > Depends on https://lore.kernel.org/linux-arm-msm/20250122-dpu-111-topology-v2-1-505e95964af9@xxxxxxxxxxxxxx/ > > --- > > .../boot/dts/qcom/sm7325-nothing-spacewar.dts | 53 ++++++++++++++++++- > > 1 file changed, 51 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts b/arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts > > index a5cda478bd78..cda317b49d5c 100644 > > --- a/arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts > > +++ b/arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts > > @@ -52,6 +52,8 @@ framebuffer0: framebuffer@e1000000 { > > stride = <(1080 * 4)>; > > format = "a8r8g8b8"; > > > > + display = <&panel0>; > > This is allowed by bindings but doesn't seem to do anything > > > + > > clocks = <&gcc GCC_DISP_HF_AXI_CLK>, > > <&dispcc DISP_CC_MDSS_MDP_CLK>, > > <&dispcc DISP_CC_MDSS_BYTE0_CLK>, > > @@ -757,6 +759,10 @@ &gpi_dma1 { > > status = "okay"; > > }; > > > > +&gpu { > > + status = "okay"; > > +}; > > + > > &gpu_zap_shader { > > firmware-name = "qcom/sm7325/nothing/spacewar/a660_zap.mbn"; > > }; > > @@ -823,15 +829,44 @@ &ipa { > > status = "okay"; > > }; > > > > -/* MDSS remains disabled until the panel driver is present. */ > > +&mdss { > > + status = "okay"; > > +}; > > + > > &mdss_dsi { > > vdda-supply = <&vdd_a_dsi_0_1p2>; > > + status = "okay"; > > > > - /* Visionox RM692E5 panel */ > > + panel0: panel@0 { > > Is there going to be a panel1, too? ;) > > Please drop the 0 No, dsi-controller.yaml requires panel@[0-3] and a reg entry. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> > > Konrad -- With best wishes Dmitry