Re: [PATCH v2 2/5] clk: qcom: lpassaudiocc-sc7280: Add support for LPASS resets for QCM6490

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 9/16/2024 2:33 PM, Krzysztof Kozlowski wrote:
On 16/09/2024 10:55, Dmitry Baryshkov wrote:
On Mon, Sep 16, 2024 at 10:33:21AM GMT, Krzysztof Kozlowski wrote:
On 13/09/2024 07:31, Taniya Das wrote:


On 8/17/2024 2:55 PM, Krzysztof Kozlowski wrote:
On 16/08/2024 10:32, Taniya Das wrote:
On the QCM6490 boards the LPASS firmware controls the complete clock
controller functionalities. But the LPASS resets are required to be
controlled from the high level OS. The Audio SW driver should be able to
assert/deassert the audio resets as required. Thus in clock driver add
support for the resets.

Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
---
   drivers/clk/qcom/lpassaudiocc-sc7280.c | 23 +++++++++++++++++++----
   1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/qcom/lpassaudiocc-sc7280.c b/drivers/clk/qcom/lpassaudiocc-sc7280.c
index 45e726477086..b64393089263 100644
--- a/drivers/clk/qcom/lpassaudiocc-sc7280.c
+++ b/drivers/clk/qcom/lpassaudiocc-sc7280.c
@@ -1,6 +1,7 @@
   // SPDX-License-Identifier: GPL-2.0-only
   /*
    * Copyright (c) 2021, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved.
    */
#include <linux/clk-provider.h>
@@ -713,14 +714,24 @@ static const struct qcom_reset_map lpass_audio_cc_sc7280_resets[] = {
   	[LPASS_AUDIO_SWR_WSA_CGCR] = { 0xb0, 1 },
   };
+static const struct regmap_config lpass_audio_cc_sc7280_reset_regmap_config = {
+	.name = "lpassaudio_cc_reset",
+	.reg_bits = 32,
+	.reg_stride = 4,
+	.val_bits = 32,
+	.fast_io = true,
+	.max_register = 0xc8,
+};
+
   static const struct qcom_cc_desc lpass_audio_cc_reset_sc7280_desc = {
-	.config = &lpass_audio_cc_sc7280_regmap_config,
+	.config = &lpass_audio_cc_sc7280_reset_regmap_config,
   	.resets = lpass_audio_cc_sc7280_resets,
   	.num_resets = ARRAY_SIZE(lpass_audio_cc_sc7280_resets),
   };
static const struct of_device_id lpass_audio_cc_sc7280_match_table[] = {
-	{ .compatible = "qcom,sc7280-lpassaudiocc" },
+	{ .compatible = "qcom,qcm6490-lpassaudiocc", .data = &lpass_audio_cc_reset_sc7280_desc },

That's odd to see sc7280 reset added for qcm6490, but not used fot
sc7280 at all. Didn't you mean here lpass_audio_cc_qcm6409_desc?


The resets descriptor(lpass_audio_cc_reset_sc7280_desc) is not part of
the global clock descriptor(lpass_cc_sc7280_desc) as these are part of
different regmaps.

On a non-QCM6490(SC7280) boards the resets are registered after the
global descriptor is registered.

But on QCM6490 board we need to register only the reset descriptor and
no clocks are to be handled/registered and thus passed the match data
for QCM6490 boards only.

Yeah, but why this is sc7280?

Because it's more or less the same HW, different TZ and hyp firmware?


Hm, ok, probably I missed something from the context.


Apologies for responding on this thread later than expected.
Yes as Dmitry mentioned, it is the same HW, TZ and HYP firmware are different.

Best regards,
Krzysztof



--
Thanks & Regards,
Taniya Das.





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux