niedz., 22 gru 2024 o 08:55 Maya Matuszczyk <maccraft123mc@xxxxxxxxx> napisał(a): > > niedz., 22 gru 2024 o 07:40 Krzysztof Kozlowski <krzk@xxxxxxxxxx> napisał(a): > > > > On 22/12/2024 07:33, Krzysztof Kozlowski wrote: > > >> +properties: > > >> + compatible: > > >> + oneOf: > > >> + - const: qcom,x1e-it8987-ec > > > > > > That's not a SoC, so I don't understand: > > > 1. referring to the SoC, > > > 2. Having this alone and as fallback. > > > > > > It does not look like you tested the bindings, at least after quick > > > look. Please run 'make dt_binding_check' (see > > > Documentation/devicetree/bindings/writing-schema.rst for instructions). > > > Maybe you need to update your dtschema and yamllint. Don't rely on > > > distro packages for dtschema and be sure you are using the latest > > > released dtschema. > > > > BTW, for sure Qualcomm did not develop/create it8987, so it cannot be > > used here. Come with specific compatible for this given, one product: > > embedded controller on one Lenovo laptop and use it also as filename. > > Under these assumptions: > > - Qualcomm developed the firmware running on the IT8987 in most x1e machines > - IT8987 is also used in other machines with a non-compatible firmware > - The driver name should reflect the assumptions > > I think the name qcom,x1e-it8987-ec is not the worst name for it, as > "ite,it8987-ec" would imply compatibility with other devices running > non-compatible firmware, > and names specifying only the device wouldn't reflect the "firmware is > based on what qcom did and it's driven the same way" part > > Which other names do you think would fit this better? In case it wasn't clear: This was a genuine question - I have no idea how to name this driver and this was the best I could come up with > > > > > Best regards, > > Krzysztof
