On 17.12.2024 11:03 AM, Varadarajan Narayanan wrote:
> From: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
>
> Enable the PCIe controller and PHY nodes for RDP 441.
>
> Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> ---
> v3: Reorder nodes alphabetically
> Fix commit subject
> ---
> arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts | 74 +++++++++++++++++++++
> 1 file changed, 74 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts
> index 846413817e9a..2be23827b481 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts
> @@ -32,6 +32,32 @@ &sdhc {
> status = "okay";
> };
>
> +&pcie0_phy {
> + status = "okay";
> +};
> +
> +&pcie0 {
Node names with suffixes sort below node names without suffixes
Python's PartialEq for strings works well for determining this
>>> 'pcie0_phy' < 'pcie0'
False
>>> 'a' < 'b'
True
> + pinctrl-names = "default";
> + pinctrl-0 = <&pcie0_default>;
Please follow this order:
property-n
property-names
> +
> + perst-gpios = <&tlmm 38 GPIO_ACTIVE_LOW>;
> + wake-gpios = <&tlmm 39 GPIO_ACTIVE_LOW>;
> + status = "okay";
And keep a newline before status
Konrad
