On 17.12.2024 11:03 AM, Varadarajan Narayanan wrote:
> From: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
>
> Add phy and controller nodes for pcie0_x1 and pcie1_x2.
>
> Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> ---
> v3: Fix compatible string for phy nodes
> Use ipq9574 as backup compatible instead of new compatible for ipq5332
> Fix mixed case hex addresses
> Add "mhi" space
> Removed unnecessary comments and stray blank lines
>
> v2: Fix nodes' location per address
> ---
>
> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 212 +++++++++++++++++++++++++-
> 1 file changed, 210 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index d3c3e215a15c..add5d50b5fb0 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -186,6 +186,46 @@ rng: rng@e3000 {
> clock-names = "core";
> };
>
> + pcie0_phy: phy@4b0000{
Please add a space before '{'
[...]
> + pcie0: pcie@20000000 {
> + compatible = "qcom,pcie-ipq9574";
> + reg = <0x00080000 0x3000>,
> + <0x20000000 0xf1d>,
> + <0x20000f20 0xa8>,
> + <0x20001000 0x1000>,
> + <0x20100000 0x1000>,
> + <0x00083000 0x1000>;
> + reg-names = "parf", "dbi", "elbi", "atu", "config", "mhi";
Please turn this into a vertical list (both controllers)
> + device_type = "pci";
> + linux,pci-domain = <0>;
> + bus-range = <0x00 0xff>;
> + num-lanes = <1>;
> + #address-cells = <3>;
> + #size-cells = <2>;
> +
> + ranges = <0x01000000 0 0x20200000 0x20200000 0 0x00100000>,
> + <0x02000000 0 0x20300000 0x20300000 0 0x0fd00000>;
> +
> + interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "msi0",
> + "msi1",
> + "msi2",
> + "msi3",
> + "msi4",
> + "msi5",
> + "msi6",
> + "msi7";
> +
[...]
> + msi-map = <0x0 &v2m0 0x0 0xffd>;
And move msi-map a line above interrupts (like in x1e80100.dtsi)
plus keep a new line between the last property and status
The rest looks good!
Konrad
