On 22.11.2024 10:27 AM, Dmitry Baryshkov wrote: > On Fri, Nov 22, 2024 at 03:14:11AM +0100, Konrad Dybcio wrote: >> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> >> >> The Surface Laptops have a Realtek RTS5261 SD Card reader connected >> over a Gen1x1 link to the PCIe3 host. Set up the necessary bits to >> make it functional. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> >> --- [...] >> >> +&pm8550ve_2_gpios { >> + sde7_main_reg_en: sde7-main-reg-en-state { >> + pins = "gpio6"; >> + function = "normal"; >> + }; >> + >> + sde7_aux_reg_en: sde7-aux-reg-en-state { >> + pins = "gpio8"; >> + function = "normal"; >> + }; >> +}; >> + >> +&pm8550ve_8_gpios { >> + vreg_12v_x8_en: 12v-x8-reg-en-state { >> + pins = "gpio8"; >> + function = "normal"; >> + }; >> +}; > > These pinctrls don't seem to be used. Moreover, two out of three are wrong ;) That's the reason for the comment about them being untouchable.. could have seen that coming. Thanks for spotting this, I'll resend shortly! Konrad