Re: [PATCH 2/5] phy: qcom: qmp: Add phy register and clk setting for QCS615 PCIe

To: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Subject: Re: [PATCH 2/5] phy: qcom: qmp: Add phy register and clk setting for QCS615 PCIe
From: Ziyue Zhang <quic_ziyuzhan@xxxxxxxxxxx>
Date: Thu, 21 Nov 2024 15:21:26 +0800
Cc: <vkoul@xxxxxxxxxx>, <kishon@xxxxxxxxxx>, <robh+dt@xxxxxxxxxx>, <manivannan.sadhasivam@xxxxxxxxxx>, <bhelgaas@xxxxxxxxxx>, <kw@xxxxxxxxx>, <lpieralisi@xxxxxxxxxx>, <quic_qianyu@xxxxxxxxxxx>, <conor+dt@xxxxxxxxxx>, <neil.armstrong@xxxxxxxxxx>, <andersson@xxxxxxxxxx>, <konradybcio@xxxxxxxxxx>, <quic_shashim@xxxxxxxxxxx>, <quic_kaushalk@xxxxxxxxxxx>, <quic_tdas@xxxxxxxxxxx>, <quic_tingweiz@xxxxxxxxxxx>, <quic_aiquny@xxxxxxxxxxx>, <kernel@xxxxxxxxxxx>, <linux-arm-msm@xxxxxxxxxxxxxxx>, <devicetree@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-phy@xxxxxxxxxxxxxxxxxxx>, "Krishna chaitanya chundru" <quic_krichai@xxxxxxxxxxx>
In-reply-to: <2rygkimclano4hcgf5vaz7eyuhcqdal5ybnh5eyci3ig2b5jcl@sq5ygemgdhwr>
References: <20241118082619.177201-1-quic_ziyuzhan@quicinc.com> <20241118082619.177201-3-quic_ziyuzhan@quicinc.com> <2rygkimclano4hcgf5vaz7eyuhcqdal5ybnh5eyci3ig2b5jcl@sq5ygemgdhwr>
User-agent: Mozilla Thunderbird

Will modified in v2

On 11/18/2024 7:15 PM, Dmitry Baryshkov wrote:

lowercase the hex. LGTM otherwise.

References:
- [PATCH 0/5] pci: qcom: Add QCS615 PCIe support
  - From: Ziyue Zhang
- [PATCH 2/5] phy: qcom: qmp: Add phy register and clk setting for QCS615 PCIe
  - From: Ziyue Zhang
- Re: [PATCH 2/5] phy: qcom: qmp: Add phy register and clk setting for QCS615 PCIe
  - From: Dmitry Baryshkov