On 30.10.2024 12:02 PM, Jens Glathe via B4 Relay wrote: > From: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx> > > Device tree for the Microsoft Windows Dev Kit 2023. This work > is based on the initial work of Merck Hung <merckhung@xxxxxxxxx>. > > Original work: https://github.com/merckhung/linux_ms_dev_kit/blob/ms-dev-kit-2023-v6.3.0/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-dev-kit-2023.dts > > The Windows Dev Kit 2023 is a nice little desktop based on sc8280xp. > Link: https://learn.microsoft.com/en-us/windows/arm/dev-kit/ > > Supported features: > - USB type-c and type-a ports > - minidp connector > - built-in r8152 Ethernet adapter > - PCIe devices > - nvme > - ath11k WiFi (WCN6855) > - WCN6855 Bluetooth > - A690 GPU > - ADSP and CDSP > - GPIO keys > - Audio definition (works via USB) > > Signed-off-by: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx> > --- [...] > + wcn6855-pmu { > + compatible = "qcom,wcn6855-pmu"; > + > + pinctrl-0 = <&bt_default>, <&wlan_en>; > + pinctrl-names = "default"; > + > + wlan-enable-gpios = <&tlmm 134 GPIO_ACTIVE_HIGH>; > + bt-enable-gpios = <&tlmm 133 GPIO_ACTIVE_HIGH>; > + > + vddio-supply = <&vreg_s10b>; > + vddaon-supply = <&vreg_s12b>; > + vddpmu-supply = <&vreg_s12b>; > + vddrfa0p95-supply = <&vreg_s12b>; > + vddrfa1p3-supply = <&vreg_s11b>; > + vddrfa1p9-supply = <&vreg_s1c>; > + vddpcie1p3-supply = <&vreg_s11b>; > + vddpcie1p9-supply = <&vreg_s1c>; Please update this atop <20241018-sc8280xp-pwrseq-v6-0-8da8310d9564@xxxxxxxxxx> most notably including a new supply (which will likely be identical) > + compatible = "qcom,sc8280xp-sndcard"; > + model = "microsoft/blackrock"; > + audio-routing = Please don't break the line, see e.g. x1e80100-crd.dts > + "SpkrLeft IN", "WSA_SPK1 OUT", > + "SpkrRight IN", "WSA_SPK2 OUT", Oh, this thing has a speaker! [...] > +&pmc8280_1_gpios { > + edp_bl_en: edp-bl-en-state { > + pins = "gpio8"; > + function = "normal"; > + }; > + > + edp_bl_reg_en: edp-bl-reg-en-state { > + pins = "gpio9"; > + function = "normal"; > + }; > + > + misc_3p3_reg_en: misc-3p3-reg-en-state { > + pins = "gpio1"; > + function = "normal"; > + }; Sorting GPIOs by their number is preferred https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes [...] > +&tlmm { > + gpio-reserved-ranges = <70 2>, <74 6>, <125 2>, <128 2>, <154 4>; Do we know what these are for? If so, please describe it (also like in x1e80100-crd.dts) Konrad
