On 31.10.24 19:54, Krishna Kurapati wrote:
On 10/30/2024 4:32 PM, Jens Glathe via B4 Relay wrote:
From: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx>
Device tree for the Microsoft Windows Dev Kit 2023. This work
is based on the initial work of Merck Hung <merckhung@xxxxxxxxx>.
Original work:
https://github.com/merckhung/linux_ms_dev_kit/blob/ms-dev-kit-2023-v6.3.0/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-dev-kit-2023.dts
The Windows Dev Kit 2023 is a nice little desktop based on sc8280xp.
Link: https://learn.microsoft.com/en-us/windows/arm/dev-kit/
Supported features:
- USB type-c and type-a ports
- minidp connector
- built-in r8152 Ethernet adapter
- PCIe devices
- nvme
- ath11k WiFi (WCN6855)
- WCN6855 Bluetooth
- A690 GPU
- ADSP and CDSP
- GPIO keys
- Audio definition (works via USB)
Signed-off-by: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx>
---
[...]
+&usb_2 {
+ pinctrl-0 = <&usb2_en_state>;
+ pinctrl-names = "default";
+
+ status = "okay";
+};
+
+&usb_2_dwc3 {
+ dr_mode = "host";
+ phy-names = "usb2-port0", "usb3-port0";
+ phys = <&usb_2_hsphy0>, <&usb_2_qmpphy0>;
+
+ status = "okay";
+};
From what I remember, the phy names for multiport must be "usb2-X" or
"usb3-X". The above notation might compile but If I am not wrong, the
phys won't be active. How was USB tested in this case ?
All 4 type-a ports are working at full capacity, I assume the phys are
up. On one of these is the internal r8152 adapter. Actually when I
started with the WDK the type-a ports were the most reliable ones. The
box is my daily driver, so its extensively tested for ~18 months now.
Moreover just marking status as "okay" for usb_2 must work like done
in [1] and [2] and there is no need for explicitly marking dr_mode as
host again and refactoring the phy-names.
[1]:
https://lore.kernel.org/all/20240707085624.3411961-1-quic_kriskura@xxxxxxxxxxx/
[2]:
https://patchwork.kernel.org/project/linux-arm-msm/patch/20240501065641.965-1-johan+linaro@xxxxxxxxxx/
Please fix this up.
will do, thank you for the hint.
with best regards
Jens
Regards,
Krishna,
