On Mon, Oct 21, 2024 at 10:21:58PM +0200, Gabor Juhos wrote: > Since neither 'alpha' nor 'alpha_hi' is defined in the configuration, > those will be initialized with zero values implicitly. By using zero > alpha values, the output rate of the PLL will be the same whether > alpha mode is enabled or not. > > Remove the superfluous initialization of the 'alpha_en_mask' member > to make it clear that enabling alpha mode is not required to get the > desired output rate. > > While at it, also add a comment to indicate the frequency the PLL > runs at with the current configuration. > > No functional changes, the initial rate of the PLL is the same both > before and after the patch. > > Tested on Xiaomi Router BE3600 2.5G (IPQ5312, out-of-tree board). > > Signed-off-by: Gabor Juhos <j4g8y7@xxxxxxxxx> > --- > drivers/clk/qcom/apss-ipq-pll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry