On 8.10.2024 6:51 PM, Dzmitry Sankouski wrote:
> Add support for max77705 MFD device. Supported sub-devices:
> charger, fuelgauge, haptic, led
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx>
> ---
[...]
> + vib_regulator: gpio-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "haptic";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-boot-on;
> + enable-active-high;
> + gpio = <&pm8998_gpios 18 GPIO_ACTIVE_HIGH>;
> + };
Please try to match the property order in the newest DTs, e.g.
vreg_wwan in x1e80100-crd.dts
> +
> + vib_pwm: pwm {
> + compatible = "clk-pwm";
> + #pwm-cells = <2>;
> + assigned-clock-parents = <&rpmhcc RPMH_CXO_CLK>;
Don't you want to set assigned-clock-rates instead?
> + assigned-clocks = <&gcc GCC_GP1_CLK_SRC>;
> + clocks = <&gcc GCC_GP1_CLK>;
> + pinctrl-0 = <&motor_pwm_default_state>;
> + pinctrl-1 = <&motor_pwm_suspend_state>;
> + pinctrl-names = "default", "suspend";
> + };
> };
Looks good otherwise
Konrad
