On Fri, Oct 25, 2024 at 02:02:20PM +0800, shaojiedong wrote: > free_pages() performs a parameter null check inside > previous code also does zero check as following > if (stack == 0) > goto out; > > to_mm->id.stack = stack; > > therefore remove double zero check here. > > Signed-off-by: shaojiedong <quic_shaojied@xxxxxxxxxxx> Is this your name? Please fix git setup. Also please don't send more than one iteration of your patchset in 24 hours. Give reviewers time to react. > --- > arch/um/kernel/skas/mmu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/um/kernel/skas/mmu.c b/arch/um/kernel/skas/mmu.c > index d3fb506d5bd6084046cf5903c629432cd42b5ab3..0eb5a1d3ba70134f75d9b2af18544fca7248c6d6 100644 > --- a/arch/um/kernel/skas/mmu.c > +++ b/arch/um/kernel/skas/mmu.c > @@ -46,8 +46,7 @@ int init_new_context(struct task_struct *task, struct mm_struct *mm) > return 0; > > out_free: > - if (new_id->stack != 0) > - free_pages(new_id->stack, ilog2(STUB_DATA_PAGES)); > + free_pages(new_id->stack, ilog2(STUB_DATA_PAGES)); > out: > return ret; > } > > --- > base-commit: fd21fa4a912ebbf8a6a341c31d8456f61e7d4170 > change-id: 20241025-upstream_branch-06a9ea92948d > > Best regards, > -- > shaojiedong <quic_shaojied@xxxxxxxxxxx> > -- With best wishes Dmitry
