On Fri, Sep 27, 2024 at 12:22:37PM +0530, Sricharan R wrote: > From: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx> > > Add binding for the Qualcomm IPQ5424 Global Clock Controller > > Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx> > --- > [v2] Added the bindings as a part of ipq5332-gcc.yaml itself. > Difference between ipq5332 and ipq5424 being 2 additional phy's. > > .../bindings/clock/qcom,ipq5332-gcc.yaml | 57 +++- > include/dt-bindings/clock/qcom,ipq5424-gcc.h | 156 +++++++++ > include/dt-bindings/reset/qcom,ipq5424-gcc.h | 310 ++++++++++++++++++ > 3 files changed, 508 insertions(+), 15 deletions(-) > create mode 100644 include/dt-bindings/clock/qcom,ipq5424-gcc.h > create mode 100644 include/dt-bindings/reset/qcom,ipq5424-gcc.h > > diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml > index 9193de681de2..aaa8b399c3b4 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml > @@ -4,31 +4,24 @@ > $id: http://devicetree.org/schemas/clock/qcom,ipq5332-gcc.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Qualcomm Global Clock & Reset Controller on IPQ5332 > +title: Qualcomm Global Clock & Reset Controller on IPQ5332 and IPQ5424 > > maintainers: > - Bjorn Andersson <andersson@xxxxxxxxxx> > > description: | > Qualcomm global clock control module provides the clocks, resets and power > - domains on IPQ5332. > + domains on IPQ5332 and IPQ5424. > > - See also:: include/dt-bindings/clock/qcom,gcc-ipq5332.h > - > -allOf: > - - $ref: qcom,gcc.yaml# > + See also:: > + include/dt-bindings/clock/qcom,gcc-ipq5332.h > + include/dt-bindings/clock/qcom,gcc-ipq5424.h > > properties: > compatible: > - const: qcom,ipq5332-gcc > - > - clocks: > - items: > - - description: Board XO clock source > - - description: Sleep clock source > - - description: PCIE 2lane PHY pipe clock source > - - description: PCIE 2lane x1 PHY pipe clock source (For second lane) > - - description: USB PCIE wrapper pipe clock source You cannot remove properties from top-level. Unify the list, so it uses common part (ipq5332) and keep it here with minItems. Then in allOf you only control min/maxItems. Best regards, Krzysztof
