On Mon, 9 Sept 2024 at 14:29, Konrad Dybcio <konradybcio@xxxxxxxxxx> wrote: > > On 9.09.2024 1:25 PM, Dmitry Baryshkov wrote: > > On Mon, 9 Sept 2024 at 13:34, Konrad Dybcio <konradybcio@xxxxxxxxxx> wrote: > >> > >> On 8.09.2024 7:59 PM, Dmitry Baryshkov wrote: > >>> Under some circumstance > >> > >> Under what circumstances? > >> > >> This branch is only taken if there's a .create_private_address_space > >> callback and it only seems to be there on a[67]xx. > > > > Existing code doesn't. I stumbled upon it while debugging private > > address space translation. And that's why I wrote 'it might be > > required' rather than 'the function returns'. > > So yes, there is no issue with the current code. And at the same time > > not having this in place makes debugging more difficult. > > Feel free to submit your debugging code in a way that won't mess > with non-debug paths then.. This is trying to solve a non-existent > issue. Ack -- With best wishes Dmitry
