On Tue, Aug 27, 2024 at 01:26:40PM +0200, Konrad Dybcio wrote:
> On 22.08.2024 4:56 PM, Johan Hovold wrote:
> > On Tue, Aug 13, 2024 at 09:06:36PM +0200, Bartosz Golaszewski wrote:
> >> From: Konrad Dybcio <konradybcio@xxxxxxxxxx>
> >> + vreg_s10b: regulator-s10b {
> >> + compatible = "regulator-fixed";
> >
> > I don't think this is a fixed regulator.
>
> It effectively is
If it's an output of one of the pmic as the name suggests and as it is
on the X13s, I think it should be described as such.
> >> +
> >> + regulator-name = "VREG_S10B";
> >> + regulator-min-microvolt = <1800000>;
> >> + regulator-max-microvolt = <1800000>;
> >> +
> >> + regulator-always-on;
> >> + regulator-boot-on;
> >> + };
> >> + wlan_en: wlan-en-state {
> >> + pins = "gpio134";
> >> + function = "gpio";
> >> + drive-strength = <8>;
> >
> > Why increase the drive strength?
>
> This is what's used on Windows, for lack of a better idea, not sure
> if this is actually necessary
If this indeed is what the fw configures it as then I guess it's fine to
keep as-is for now.
Johan
