On 12 May 2016 at 05:48, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote: > On 05/11, Pramod Gurav wrote: >> msm_serial driver provides a .pm callback to the serial core to enable >> and disable clock resource in suspend/resume path. This function is >> also called before msm_startup. msm_startup also enables the clocks which >> is not needed. Hence remove the duplcate clock operation from msm_startup >> and msm_shutdown. Same is done in console setup to get rid of duplicate >> clock operation. > > I had to check and I see that for the console case we call the > .pm callback and don't turn it off until suspend/resume paths > (would be nice to add suspend/resume to this driver too). I > guess that's what you meant by this last sentence? > Yes the clocks would be kept ON if its console. I am working to add suspend/resume and runtime pm as it will not happen by default through core. >> >> Tested on DB410C console. >> >> Signed-off-by: Pramod Gurav <pramod.gurav@xxxxxxxxxx> > > Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx> > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
