On 7/30/2024 10:39 PM, Krzysztof Kozlowski wrote: > On 31/07/2024 00:24, Elson Roy Serrao wrote: >> The Embedded USB Debugger(EUD) is a HS-USB on-chip hub to support the >> debug and trace capabilities on Qualcomm devices. It is physically >> present in between the usb connector and the usb controller. Being a >> HS USB hub, it relies on HS Phy for its functionality. Add HS phy >> support in the eud driver and control the phy during eud enable/disable >> operations. >> > > ... >> static ssize_t enable_show(struct device *dev, >> @@ -186,6 +216,11 @@ static int eud_probe(struct platform_device *pdev) >> >> chip->dev = &pdev->dev; >> >> + chip->usb2_phy = devm_phy_get(chip->dev, "usb2-phy"); >> + if (IS_ERR(chip->usb2_phy)) >> + return dev_err_probe(chip->dev, PTR_ERR(chip->usb2_phy), >> + "no usb2 phy configured\n"); > > This nicely breaks all users. > > NAK > As per my comment in [patch 1/8], phy would be a required property and hence I will first modify and enable EUD on the existing user (sc7280 SoC) and then extend this to other users. Thanks Elson
