On Tue, 9 Jul 2024 at 00:27, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > > On 8.07.2024 2:49 PM, Dmitry Baryshkov wrote: > > On Mon, 8 Jul 2024 at 14:07, Marc Gonzalez <mgonzalez@xxxxxxxxxx> wrote: > >> > >> On 05/07/2024 16:34, Dmitry Baryshkov wrote: > > [...] > > >>> I'm not going to check the math, but it looks pretty close to what we > >>> have for msm8996. > >> > >> What is the consequence of this? > > > > That I won't check the math :-D > > Dmitry is trying to say that you should check whether the calculations > are the same or almost the same as in the 8996 driver, and if so, try > to commonize the code between the two Not quite :-D They are slightly different. More importantly, this is a different version of QMP PHY. So, it's not really worth merging the code. Earlier on I pasted the patchset to move all HDMI PHY drivers to drivers/phy/qualcomm. I plan to integrate msm8998 support into that patchset (this should not be delaying this patch though). But I don't want to commonize the HDMI QMP PHY code before somebody implements support for the third version of QMP HDMI PHYs, the one that is found on msm8992/94. -- With best wishes Dmitry
