On Thu, Jul 04, 2024 at 06:45:36PM GMT, Marc Gonzalez wrote:
> From: Arnaud Vrac <avrac@xxxxxxxxxx>
>
> Ported from the downstream driver.
Please write some sensible commit message.
>
> Signed-off-by: Arnaud Vrac <avrac@xxxxxxxxxx>
> Signed-off-by: Marc Gonzalez <mgonzalez@xxxxxxxxxx>
> ---
> drivers/gpu/drm/msm/Makefile | 1 +
> drivers/gpu/drm/msm/hdmi/hdmi.c | 1 +
> drivers/gpu/drm/msm/hdmi/hdmi.h | 8 +
> drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 5 +
> drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 789 +++++++++++++++++++++++++
> drivers/gpu/drm/msm/registers/display/hdmi.xml | 89 +++
> 6 files changed, 893 insertions(+)
- Missing changelog
- Missing a pointer to bindings. Ideally bindings should come together
with the driver.
I'm not going to check the math, but it looks pretty close to what we
have for msm8996.
> +
> +static const char * const hdmi_phy_8998_reg_names[] = {
> + "vdda-pll",
> + "vdda-phy",
Unless you have a strong reason to, please use vcca and vddio here, so
that we don't have unnecessary conditionals in schema.
--
With best wishes
Dmitry
