On Wed, Jul 03, 2024 at 01:49:15PM +0300, Dmitry Baryshkov wrote: > On Wed, Jul 03, 2024 at 02:46:49PM GMT, Varadarajan Narayanan wrote: > > From: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx> > > > > * Add thread, scaling factor, CPR descriptor defines to enable > > CPR on IPQ9574. > > > > * Skip 'acc' usage since IPQ9574 does not have acc > > > > Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx> > > Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> > > --- > > v4: s/silver//, s/cprh/cpr4/ > > Skip 'acc' related code as IPQ9574 does not have acc > > > > v3: Fix patch author > > Included below information in cover letter > > v2: Fix Signed-off-by order > > Depends: > > [1] https://lore.kernel.org/lkml/20230217-topic-cpr3h-v14-0-9fd23241493d@xxxxxxxxxx/T/ > > [2] https://github.com/quic-varada/cpr/commits/konrad/ > > --- > > drivers/pmdomain/qcom/cpr3.c | 143 ++++++++++++++++++++++++++++++++++- > > 1 file changed, 141 insertions(+), 2 deletions(-) > > > > > > > @@ -2703,7 +2840,8 @@ static int cpr_probe(struct platform_device *pdev) > > > > mutex_init(&drv->lock); > > > > - if (desc->cpr_type < CTRL_TYPE_CPRH) { > > + if (desc->cpr_type < CTRL_TYPE_CPRH && > > + !of_device_is_compatible(dev->of_node, "qcom,ipq9574-cpr4")) { > > No. Check for ->acc_desc instead. Ok. Thanks Varada > > np = of_parse_phandle(dev->of_node, "qcom,acc", 0); > > if (!np) > > return -ENODEV; > > @@ -2828,6 +2966,7 @@ static void cpr_remove(struct platform_device *pdev) > > } > > > > static const struct of_device_id cpr3_match_table[] = { > > + { .compatible = "qcom,ipq9574-cpr4", .data = &ipq9574_cpr_acc_desc }, > > { .compatible = "qcom,msm8998-cprh", .data = &msm8998_cpr_acc_desc }, > > { .compatible = "qcom,sdm630-cprh", .data = &sdm630_cpr_acc_desc }, > > { } > > -- > > 2.34.1 > > > > -- > With best wishes > Dmitry
