On Thu, Jun 27, 2024 at 11:40 PM Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> wrote: > > On 26/06/2024 10:04, george chan wrote: > > On Wed, Jun 26, 2024 at 4:58 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > >> > >> On 26/06/2024 10:38, george chan wrote: > >>> On Wed, Jun 26, 2024 at 4:17 PM george chan <gchan9527@xxxxxxxxx> wrote: > >>>> > >>>> On Wed, Jun 26, 2024 at 3:15 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > >>>>> Keep the list in "required:" in the same order as the list in "properties:". > >>>> > >>>> ok gotcha > >>> btw, i checked "required:" and "properties:" are aligned, both of > >> > >> No, they are not. > >> > >> Which is the first entry in "properties"? > >> > >> Which is the first entry in "required"? > >> > >> Please stop wasting reviewers time by disagreeing on every little piece > >> of this. The feedback was quite clear but somehow you do not read it and > >> respond with some inaccurate statements. > >> > >> Best regards, > >> Krzysztof > >> > > > > Then my apology. I might take a break here. Appreciated if some > > developer is willing to take over it too. > > George are you resending this with Krzysztof's comments addressed ? > > I'm trying to figure out what we are targeting for merge. > > --- > bod Since my phone is EOL, I can't test new patches so I can only give up from here. My suggestion is to drop this atm and let sc7280 patches get in early.
