On Wed, Jun 26, 2024 at 4:17 PM george chan <gchan9527@xxxxxxxxx> wrote: > > On Wed, Jun 26, 2024 at 3:15 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > Keep the list in "required:" in the same order as the list in "properties:". > > ok gotcha btw, i checked "required:" and "properties:" are aligned, both of them are in ascending order. I am wondering if you are talking about two things, 1st one is to align both property, and 2nd is having the ordering like below. Plz confirm. required: - compatible - reg - reg-names - interrupt-names - interrupts - clock-names - clocks - iommus - power-domains - power-domain-names - vdda-phy-supply - vdda-pll-supply > > >> BTW, I asked for subject to keep only one, first "media" prefix: > > >> "Subject: just one media (first). " > > >> but you kept the second "media". > > > > > > Sorry I can't get it. Could you choose one? > > > > > > _ORIGINAL_ > > > dt-bindings: media: camss: Add qcom,sc7180-camss > > > > No, original was different. Go back to your first posting. I asked to > > remove one media and keep only one - the first. I did not ask to > > re-shuffle the prefixes. > Yes, let me sum it up > > v1 title is w.r.t > https://patchwork.kernel.org/project/linux-arm-msm/patch/20240222-b4-camss-sc8280xp-v6-1-0e0e6a2f8962@xxxxxxxxxx/ > then extra "camss" pre-fix keyword and "binding" post-fix is not needed. > v2 wrongly remove all prefixes and correctly removed post-fix > v3 added correct prefix, removed redundancy "camss" prefixes but > changelog still refer to old sc8280xp style > > The title now should be fine. So I will modify the changelog only. > > So there are 2 todo items as above. Other than above, all review items > are addressed. Plz confirm.
