On Wed, Jun 19, 2024 at 9:27 PM Andrew Lunn <andrew@xxxxxxx> wrote: > > On Wed, Jun 19, 2024 at 08:45:46PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > > > Checking the firmware register before it boots makes no sense, it will > > report 0 even if FW is loaded. Always wait for FW to boot before > > continuing. > > Please split this patch up. One patch which renames the method to the > more generic aqr_ since it is used by more than aqr107. Then add the > new use of it. > Will do. > Is this actually a fix? What happens to the firmware if you try to > download it while it is still booting? Or do you end up downloading > firmware when it is not actually needed? Please expand the commit > message. > It says '0' and the driver tries to load it from nvmem, then the filesystem and bails-out after these two fail. I'll extend the commit message. Bart > Andrew > > --- > pw-bot: cr
