On Tue, Jun 4, 2024 at 1:55 PM Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > > > > On 6/4/24 02:20, Barnabás Czémán wrote: > > From: Daniil Titov <daniilt971@xxxxxxxxx> > > > > This GPU is found on SoCs such as MSM8937 (450 MHz), MSM8940 (475 MHz), > > SDM439 (650 MHz). > > > > Signed-off-by: Daniil Titov <daniilt971@xxxxxxxxx> > > Signed-off-by: Barnabás Czémán <trabarni@xxxxxxxxx> > > --- > > This all looks very good, just a nit > > [...] > > > + /* > > + * Increase inactive period to 250 to avoid bouncing > > + * the GDSC which appears to make it grumpy > > + */ > > + .inactive_period = 250, > > Are you sure this is actually necessary? Every A5XX GPU is using the same value, but i have never tried with DRM_MSM_INACTIVE_PERIOD. > > Konrad
