On Tue, May 07, 2024 at 08:16:45PM +0300, Andy Shevchenko wrote:
> On Tue, May 7, 2024 at 6:01 PM Johan Hovold <johan@xxxxxxxxxx> wrote:
> > On Mon, May 06, 2024 at 09:56:05PM +0300, Andy Shevchenko wrote:
> > > Mon, May 06, 2024 at 05:08:19PM +0200, Johan Hovold kirjoitti:
> > > > The regmap irq array is potentially shared between multiple PMICs and
>
> ...
>
> > > > - dev_err(dev, "Failed to probe irq periphs: %d\n", rc);
> > > > + dev_err(dev, "failed to add IRQ chip: %d\n", rc);
> > >
> > > dev_err_probe(...); ?
> >
> > This function won't return -EPROBE_DEFER,
>
> This is not an argument for a long time (since documentation of
> dev_err_probe() had been amended to encourage its use for any error
> cases in probe).
There was apparently a kernel doc update made in December 2023:
532888a59505 ("driver core: Better advertise dev_err_probe()")
to clarify that people are *allowed* to use it also for functions not
returning -EPROBE_DEFER. That's hardly a long time ago and, importantly,
this is of course still nothing that is *required*.
> > and that would be a separate
> > change in any case.
>
> Sure, but why to add a technical debt? Perhaps a precursor cleanup patch?
This is not in any way technical debt.
Johan
