Mon, May 06, 2024 at 05:08:19PM +0200, Johan Hovold kirjoitti: > The regmap irq array is potentially shared between multiple PMICs and IRQ > should only contain static data. > > Use a custom macro to initialise also the type fields and drop the > unnecessary updates on each probe. ... > +#define _IRQ_TYPE_ALL (IRQ_TYPE_EDGE_BOTH | IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_LEVEL_LOW) This is repetition of IRQ_TYPE_DEFAULT. ... > - dev_err(dev, "Failed to probe irq periphs: %d\n", rc); > + dev_err(dev, "failed to add IRQ chip: %d\n", rc); dev_err_probe(...); ? -- With Best Regards, Andy Shevchenko
