On Wed, 17 Apr 2024 at 09:50, Herman van Hazendonk <github.com@xxxxxxxxxx> wrote: > > On Wed, 17 Apr 2024 at 07:52, Herman van Hazendonk > <github.com@xxxxxxxxxx> wrote: > >> > >> Adds qcom,usb-hs-phy-msm8660 compatible > >> > >> Used by HP Touchpad (tenderloin) for example. > >> > >> Signed-off-by: Herman van Hazendonk <github.com@xxxxxxxxxx> > >> --- > >> Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > >> index f042d6af1594..ccf23170cd17 100644 > >> --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > >> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > >> @@ -15,6 +15,7 @@ if: > >> contains: > >> enum: > >> - qcom,usb-hs-phy-apq8064 > >> + - qcom,usb-hs-phy-msm8660 > >> - qcom,usb-hs-phy-msm8960 > >> then: > >> properties: > >> @@ -41,6 +42,7 @@ properties: > >> - enum: > >> - qcom,usb-hs-phy-apq8064 > >> - qcom,usb-hs-phy-msm8226 > >> + - qcom,usb-hs-phy-msm8960 > > > This should probably be msm8660 rather than 8960 > Hi Dmitry, > > Thanks for the swift feedback. I'll send a v3. > I need more coffee before doing this in the morning Please wait for the feedback from bindings maintainers (this might take a couple of days). > > Note, nowadays the rule would be to use qcom,msm8660-usb-hs-phy > > compatible, but I wonder if we should enforce this for such an old > > platform or whether similarity wins. > > >> - qcom,usb-hs-phy-msm8916 > >> - qcom,usb-hs-phy-msm8960 > >> - qcom,usb-hs-phy-msm8974 > >> > > I plan to send more patches for the msm8660, so happy to understand what > is the preferred approach, because it doesn't seem consistent. > > These are my first patches, so learning mainly from what I see in commit > history (which might be outdated) > It's indeed ancient platform, we just would like to get HP TouchPad > (tenderloin) running with a mainline kernel, hence these patches. This sounds really interesting. I recently got apq8060 so I should be able to test your patches if the time permits. -- With best wishes Dmitry
