On 08/04/2024 20:36, Luca Weiss wrote: > On Montag, 8. April 2024 19:26:49 CEST Konrad Dybcio wrote: >> >> On 4/8/24 18:39, Luca Weiss wrote: >>> Allow specifying a GPIO hog, as already used on >>> qcom-msm8974-lge-nexus5-hammerhead.dts. >>> >>> Signed-off-by: Luca Weiss <luca@xxxxxxxxx> >>> --- >>> .../devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml >>> index a786357ed1af..510a05369dbb 100644 >>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml >>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml >>> @@ -424,6 +424,10 @@ patternProperties: >>> $ref: "#/$defs/qcom-pmic-gpio-state" >>> additionalProperties: false >>> >>> + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": >> >> I see a couple bindings do this, but I'm not sure if we want two >> allow two styles for no reason.. Rob? > > This regex is actually from the gpio-hog.yaml base > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/gpio/gpio-hog.yaml#L23 > > Why it's made this way I cannot tell you, but I didn't want to 'artifically' > restrict the pattern for qcom,pmic-gpio. Use the same as in tlmm: https://lore.kernel.org/linux-devicetree/20221121081221.30745-1-krzysztof.kozlowski@xxxxxxxxxx/ Best regards, Krzysztof
