On 25/03/2024 19:16, Odelu Kukatla wrote: > Added clock property to enable clocks required for accessing > qos registers. > > Signed-off-by: Odelu Kukatla <quic_okukatla@xxxxxxxxxxx> > --- > .../bindings/interconnect/qcom,sc7280-rpmh.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml > index b135597d9489..950ecdd5252e 100644 > --- a/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml > +++ b/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml > @@ -35,6 +35,10 @@ properties: > reg: > maxItems: 1 > > + clocks: > + minItems: 1 > + maxItems: 2 Why is this flexible? Nothing in commit msg explains that. I gave the same talk twice, gave there examples, yet it is not enough... https://elixir.bootlin.com/linux/v6.8/source/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml#L132 > + > required: > - compatible > > @@ -57,6 +61,7 @@ unevaluatedProperties: false > > examples: > - | > + #include <dt-bindings/clock/qcom,gcc-sc7280.h> > interconnect { > compatible = "qcom,sc7280-clk-virt"; > #interconnect-cells = <2>; > @@ -69,3 +74,12 @@ examples: > #interconnect-cells = <2>; > qcom,bcm-voters = <&apps_bcm_voter>; If all devices have clocks, then you could add them here. It seems not all of them have clocks... Best regards, Krzysztof
