Re: [PATCH] mtd: rawnand: qcom: Fix broken misc_cmd_type in exec_op

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



manivannan.sadhasivam@xxxxxxxxxx wrote on Fri, 22 Mar 2024 20:35:10

> On Wed, Mar 20, 2024 at 01:11:39AM +0100, Christian Marangi wrote:
> > misc_cmd_type in exec_op have multiple problems. With commit a82990c8a409
> > ("mtd: rawnand: qcom: Add read/read_start ops in exec_op path") it was
> > reworked and generalized but actually dropped the handling of the
> > RESET_DEVICE command.
> > 
> > The rework itself was correct with supporting case where a single misc
> > command is handled, but became problematic by the addition of exiting
> > early if we didn't had an ERASE or an OP_PROGRAM_PAGE operation.
> > 
> > Also additional logic was added without clear explaination causing the
> > erase command to be broken on testing it on a ipq806x nandc.
> >   
> Interesting. I believe Alam tested the rework on IPQ platforms and not sure how
> it got missed.
> > Add some additional logic to restore RESET_DEVICE command handling and
> > fix erase command.
> >   
> This sounds like two independent fixes, no? Please split them into separate
> patches.

Might be split indeed. @Christian, do you plan on sending a v2?


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux