On Thu, Mar 21, 2024 at 08:25:15AM +0100, Krzysztof Kozlowski wrote: > On 21/03/2024 05:31, Varadarajan Narayanan wrote: > > Unlike MSM platforms that manage NoC related clocks and scaling > > from RPM, IPQ SoCs dont involve RPM in managing NoC related > > clocks and there is no NoC scaling. > > If these are clocks, expose them as clocks, not as interconnects. Earlier IPQ9574 PCIe patches were NAK-ed when these were exposed as clocks. Please refer to the following discussions https://lore.kernel.org/linux-arm-msm/CAA8EJpq0uawrOBHA8XHygEpGYF--HyxJWxKG44iiFdAZZz7O2w@xxxxxxxxxxxxxx/ https://lore.kernel.org/linux-arm-msm/CAA8EJppabK8j9T40waMv=t-1aksXfqJibWuS41GhruzLhpatrg@xxxxxxxxxxxxxx/ Dmitry had said <quote> I'd kindly suggest implementing the NoC attachment properly. In the end, other Qualcomm platforms use ICC drivers, so by following this pattern we will have more common code paths. </quote> Hence posted these patches to get feedback. > > However, there is a requirement to enable some NoC interface > > clocks for accessing the peripheral controllers present on > > these NoCs. > > > > Hence adding a minimalistic interconnect driver that can enable > > the relevant clocks. This is similar to msm8996-cbf's usage of > > icc-clk framework. > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> > > --- > > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 2 + > > DTS is always, ALWAYS, separate. Ok. > > > drivers/clk/qcom/gcc-ipq9574.c | 75 ++++++++++++++++++++++++++- > > 2 files changed, 76 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > > index 7f2e5cbf3bbb..efffbd085715 100644 > > --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi > > +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > > @@ -11,6 +11,7 @@ > > #include <dt-bindings/interrupt-controller/arm-gic.h> > > #include <dt-bindings/reset/qcom,ipq9574-gcc.h> > > #include <dt-bindings/thermal/thermal.h> > > +#include <dt-bindings/interconnect/qcom,ipq9574.h> > > Keep the order, Ok. Thanks Varada
