On Mon, 4 Mar 2024 at 20:27, Russell King (Oracle) <linux@xxxxxxxxxxxxxxx> wrote: > > On Mon, Mar 04, 2024 at 08:21:36PM +0100, Robert Marko wrote: > > - if (IS_ENABLED(CONFIG_GPIOLIB)) { > > +#if IS_ENABLED(CONFIG_GPIOLIB) > > /* Make sure we don't have mixed leds node and gpio-controller > > * to prevent registering leds and having gpio-controller usage > > * conflicting with them. > > @@ -749,7 +749,7 @@ static int qca807x_probe(struct phy_device *phydev) > > if (ret) > > return ret; > > } > > - } > > +#endif > > I know it makes for a bigger patch, but #if is not equivalent to if() > in terms of indentation, so the indentation also needs to be changed. Oh, sorry for that, it completely slipped my mind. I will fix it in v2, and will send it tomorrow afternoon to give others time to comment. Regards, Robert > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!