On 23.02.2024 15:48, Krishna chaitanya chundru wrote:
> To access PCIe registers, PCIe BAR space, config space the CPU-PCIe
> ICC(interconnect consumers) path should be voted otherwise it may
> lead to NoC(Network on chip) timeout. We are surviving because of
> other driver vote for this path.
> As there is less access on this path compared to PCIe to mem path
> add minimum vote i.e 1KBps bandwidth always.
>
> In suspend remove the disable this path after register space access
> is done.
>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@xxxxxxxxxxx>
> ---
[...]
>
> + /* Remove cpu path vote after all the register access is done */
> + ret = icc_disable(pcie->icc_cpu);
> + if (ret) {
> + dev_err(dev, "failed to disable icc path of cpu-pcie: %d\n", ret);
> + if (pcie->suspended) {
> + qcom_pcie_host_init(&pcie->pci->pp);
> + pcie->suspended = false;
> + }
> + qcom_pcie_icc_opp_update(pcie);
This doesn't compile (you rename it in patch 6, this is patch 3)
Konrad
