On 21/02/2024 13:52, Abel Vesa wrote:
> Add dedicated schema for PMIC ARB v7 as it allows multiple
> buses by declaring them as child nodes. These child nodes
> will follow the generic spmi bus bindings.
>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> ---
> +
> +description: |
> + The SPMI PMIC Arbiter v7 is found on Snapdragon chipsets. It is an SPMI
> + controller with wrapping arbitration logic to allow for multiple on-chip
> + devices to control up to 2 SPMI separate buses.
> +
> + The PMIC Arbiter can also act as an interrupt controller, providing interrupts
> + to slave devices.
> +
> +properties:
> + compatible:
> + const: qcom,spmi-pmic-arb-v7
I dislike the versioning. Previous PMIC ARB binding said "it will cover
everything" and now it turns out that everything is not everything. I
would suggest SoC specific compatibles.
> +
> + reg:
> + items:
> + - description: core registers
> + - description: tx-channel per virtual slave regosters
> + - description: rx-channel (called observer) per virtual slave registers
> +
> + reg-names:
> + items:
> + - const: core
> + - const: chnls
> + - const: obsrvr
> +
> + ranges: true
> +
> + '#address-cells':
> + const: 2
> +
> + '#size-cells':
> + const: 2
> +
> + qcom,ee:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0
> + maximum: 5
> + description: >
> + indicates the active Execution Environment identifier
> +
> + qcom,channel:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0
> + maximum: 5
> + description: >
> + which of the PMIC Arb provided channels to use for accesses
We should probably deprecate qcom,bus-id in qcom,spmi-pmic-arb.yaml.
> +
> +patternProperties:
> + "spmi@[0-1]$":
> + type: object
> + $ref: /schemas/spmi/spmi.yaml
On this level:
unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg-names
> + - qcom,ee
> + - qcom,channel
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + spmi: arbiter@c400000 {
> + compatible = "qcom,spmi-pmic-arb-v7";
> + reg = <0x0c400000 0x3000>,
> + <0x0c500000 0x4000000>,
> + <0x0c440000 0x80000>;
> + reg-names = "core", "chnls", "obsrvr";
> +
> + qcom,ee = <0>;
> + qcom,channel = <0>;
> +
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + spmi_bus0: spmi@0 {
> + reg = <0 0x0c42d000 0 0x4000>,
> + <0 0x0c4c0000 0 0x10000>;
> + reg-names = "cnfg", "intr";
> +
> + interrupt-names = "periph_irq";
> + interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-controller;
> + #interrupt-cells = <4>;
> +
> + qcom,bus-id = <0>;
Please drop. Same in second instance.
Best regards,
Krzysztof
