Hi, On Fri, Feb 9, 2024 at 11:10 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-clamshell.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-clamshell.dtsi > new file mode 100644 > index 000000000000..bcf3df463f80 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-clamshell.dtsi > @@ -0,0 +1,9 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Google Trogdor dts framgent for clamshells s/framgent/fragment > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-detachable.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-detachable.dtsi > new file mode 100644 > index 000000000000..ab0f30288871 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-detachable.dtsi > @@ -0,0 +1,12 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Google Trogdor dts framgent for detachables s/framgent/fragment > + * Copyright 2024 Google LLC. > + */ > + Tiny nit: should this file have a comment like "/* This file must be included after sc7180-trogdor.dtsi */" like the clamshell file? > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi > index e9f213d27711..c3fd6760de7a 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi > @@ -5,8 +5,7 @@ > * Copyright 2020 Google LLC. > */ > > -/* This file must be included after sc7180-trogdor.dtsi */ > -#include <arm/cros-ec-keyboard.dtsi> > +#include "sc7180-trogdor-clamshell.dtsi" nit: Not that it was terribly consistent before, but in lazor you remove the "This file must be included after sc7180-trogdor.dtsi" because (I guess) it moved to the clamshell file. However, in other dts files you don't remove it. pazquel has the exact same comment and it's not removed. Pompom has a slight variant of the comment where it explains the reason (to modify cros_ec) and it's not removed. Could make it more consistent... Everything above is either tiny typos or nits, so happy enough with: Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
