On Sat, 10 Feb 2024 at 09:17, Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > At a high-level, detachable Trogdors (sometimes known as Strongbads) > don't have a cros_ec keyboard, while all clamshell Trogdors (only known > as Trogdors) always have a cros_ec keyboard. Looking closer though, all > clamshells have a USB type-A connector and a hardwired USB camera. And > all detachables replace the USB camera with a MIPI based one and swap > the USB type-a connector for the detachable keyboard pogo pins. > > Split the detachable and clamshell bits into different files so we can > describe these differences in one place instead of in each board that > includes sc7180-trogdor.dtsi. For now this is just the keyboard part, > but eventually this will include the type-a port and the pogo pins. > > Cc: <cros-qcom-dts-watchers@xxxxxxxxxxxx> > Cc: Andy Gross <agross@xxxxxxxxxx> > Cc: Bjorn Andersson <andersson@xxxxxxxxxx> > Cc: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> > Cc: Conor Dooley <conor+dt@xxxxxxxxxx> > Cc: <linux-arm-msm@xxxxxxxxxxxxxxx> > Cc: <devicetree@xxxxxxxxxxxxxxx> > Cc: Pin-yen Lin <treapking@xxxxxxxxxxxx> > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > --- > .../boot/dts/qcom/sc7180-trogdor-clamshell.dtsi | 9 +++++++++ > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 5 +---- > .../boot/dts/qcom/sc7180-trogdor-detachable.dtsi | 12 ++++++++++++ > .../arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi | 7 +------ > .../boot/dts/qcom/sc7180-trogdor-kingoftown.dts | 2 +- > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 3 +-- > arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 2 +- > .../boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi | 7 +------ > arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 2 +- > .../boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi | 5 +---- > 11 files changed, 30 insertions(+), 26 deletions(-) > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-clamshell.dtsi > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-detachable.dtsi > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry
