On Thu, 1 Feb 2024 at 06:00, Chukun Pan <amadeus@xxxxxxxxxx> wrote: > > Hi, Dmitry > > Straight to the board files, please, no need for additional includes. > > Is it possible to move the mp5496 node to mp5496.dtsi? > Because ipq9574 also uses this mp5496 pmic. > > &rpm_requests { > regulators { > compatible = "qcom,rpm-mp5496-regulators"; > > mp5496_s1: s1 { > regulator-min-microvolt = <725000>; > regulator-max-microvolt = <1075000>; > status = "disabled"; > }; > > mp5496_s2: s2 { > regulator-min-microvolt = <725000>; > regulator-max-microvolt = <1062500>; > status = "disabled"; > }; > > mp5496_l2: l2 { > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <3300000>; > status = "disabled"; > }; > }; > }; Usually this is a bad idea, the regulator boundaries are board specific. > > > From your patches I had the feeling that you still want to limit the > > high-frequency OPP entries if there is no PMIC. > > Sorry for this misunderstanding, the cpu max frequency is determined > by the cpu_speed_bin. It's just that the efuse of the board I have > without pmic are all 1.2GHz. Ack, sounds good then. -- With best wishes Dmitry