On Wed, Jan 24, 2024 at 8:55 PM Priyansh Jain <quic_priyjain@xxxxxxxxxxx> wrote: > > > > On 1/24/2024 6:04 PM, Konrad Dybcio wrote: > > > > > > On 1/24/24 11:42, Priyansh Jain wrote: > >> > >> As part of suspend to RAM, tsens hardware will be turned off and it > >> cannot generate any interrupt.Also system doesn't want to abort > >> suspend to RAM due to tsens interrupts since system is already going > >> into lowest > >> power state. Hence disabling tsens interrupt during suspend to RAM > >> callback. > > > > Is that a hardware limitation, or a software design choice? I'm not > > sure I want my phone to have thermal notifications disabled when > > it's suspended. > > > Konrad > > As part of suspend to RAM , entire SOC will be off, this mode (suspend > to RAM) is not intended for Mobile product. Tsens interrupts are not > disabled as part of suspend to idle(suspend mode for mobile). You should hide the callbacks behind the CONFIG_SUSPEND Kconfig option so that it only gets enabled when S2R is enabled.