Hi Konrad, On 1/25/2024 3:15 PM, Konrad Dybcio wrote: > > > On 1/25/24 09:26, Dmitry Baryshkov wrote: >> On Thu, 25 Jan 2024 at 10:10, Umang Chheda <quic_uchheda@xxxxxxxxxxx> wrote: >>> >>> Hi Dmitry, >>> >>> On 1/23/2024 5:48 PM, Dmitry Baryshkov wrote: >>>> On Tue, 23 Jan 2024 at 12:28, Umang Chheda <quic_uchheda@xxxxxxxxxxx> wrote: >>>>> >>>>> qcm6490-idp platform supports PM7250B PMIC as well. >>>>> Add support for the same. >>>> >>>> The platform can not "support" PMIC. Please fix the commit message. >>> Shall I change the commit message as below in the next patch ? >>> "Add PM7250B PMIC support for qcm6490-idp" >> >> This is also not accurate. You are not adding support for the PMIC. >> You are describing PMICs present on the board. > > Umang, consider one of: > > arm64: dts: qcom: qcm6490-idp: > > "Include PM7250B" > > "Enable PM7250B" > > "Configure PM7250B" > Ack, I have sent new version of my patch which addresses the feedback. > Konrad Thanks, Umang
