Re: [net-next PATCH 1/3] dt-bindings: net: ipq4019-mdio: document now supported clock-frequency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 24, 2024 at 11:27:20PM +0100, Christian Marangi wrote:
> On Wed, Jan 24, 2024 at 11:23:05PM +0100, Andrew Lunn wrote:
> > > +  clock-frequency:
> > > +    description:
> > > +      The MDIO bus clock that must be output by the MDIO bus hardware, if
> > > +      absent, the default hardware values are used.
> > > +
> > > +      MDC rate is feed by an external clock (fixed 100MHz) and is divider
> > > +      internally. The default divider is /256 resulting in the default rate
> > > +      applied of 390KHz.
> > > +    enum: [ 390625, 781250, 1562500, 3125000, 6250000, 12500000 ]
> > 
> > Hi Christian
> > 
> > 802.3 says the clock should be up to 2.5MHz by default. So the nearest
> > would be 1562500. Please document that if not set, it defaults to
> > this. And make the driver actually default to that.
> >
> 
> As I said, this is very fk up and default value is 390KHz unless anyone
> in the chain sets it (sometime uboot does it but it's not that common...
> default qsdk uboot doesn't do that for example)... Ok I have to change
> this to default to 1562500.

I doubt you will cause any regression by defaulting to 2.5HHz
instead. That is what the standard says it should be. All devices on
the bus should support that.

    Andrew




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux