On Mon, 2024-01-22 at 16:17 +0100, Krzysztof Kozlowski wrote: > On 22/01/2024 15:51, Rong Zhang wrote: > > I've glanced similar dts. To solve this, I think we could either: > > 1. keep the dt-binding in [PATCH 3/4], and delete "samsung,klte" here > > 2. rewrite dt-binding like crystalfontz,cfa100{36,37,49,55,56,57,58}: [...] > > My preference is (2.) since other variants of klte may be added in the > > future. I would like to hear your preferences. > > It depends whether the devices are compatible. IOW, entire klte DTB > should work fine on kltechn, just without few new devices. Yes, they are compatible. I'd used the klte DTB on kltechn for a long time before I made this patchset. It worked totally fine expect for LEDs and WiFi, as I've said in the cover letter. Thanks, Rong > Best regards, > Krzysztof >