On 21.01.2024 16:39, Rong Zhang wrote: > This device has little difference compared to Samsung Galaxy S5 (klte), > so the device tree is based on qcom-msm8974pro-samsung-klte.dts. The > only difference is the gpio pins of i2c_led_gpio. With pins corrected, > the LEDs and WiFi are able to work properly. > > Signed-off-by: Rong Zhang <i@xxxxxxxx> > --- Looks like you didn't change the brcm,board-type though? [...] > +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-kltechn.dts > @@ -0,0 +1,16 @@ > +// SPDX-License-Identifier: GPL-2.0 > +#include "qcom-msm8974pro-samsung-klte.dts" It's customary not to include .dts files, instead split the common parts into e.g. qcom-msm8974pro-samsung-klte-common.dtsi and include this in both the existing and the new one. Konrad
