Re: [PATCH] soc: qcom: rpmh-rsc: Enhance check for VREG in-flight request

["Maulik Shah (mkshah)" <quic_mkshah@xxxxxxxxxxx>]

Hi,

On 1/17/2024 5:19 PM, Konrad Dybcio wrote:

> > diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
> > index a021dc71807b..5371d7e3090a 100644
> > --- a/drivers/soc/qcom/rpmh-rsc.c
> > +++ b/drivers/soc/qcom/rpmh-rsc.c
> > @@ -1,6 +1,7 @@
> >   // SPDX-License-Identifier: GPL-2.0
> >   /*
> >    * Copyright (c) 2016-2018, The Linux Foundation. All rights reserved.
> > + * Copyright (c) 2023-2024, Qualcomm Innovation Center, Inc. All 
> > rights reserved.
> >    */
> >   #define pr_fmt(fmt) "%s " fmt, KBUILD_MODNAME
> > @@ -91,6 +92,15 @@ enum {
> >   #define CMD_STATUS_ISSUED        BIT(8)
> >   #define CMD_STATUS_COMPL        BIT(16)
> > +#define ACCL_TYPE(addr)            ((addr >> 16) & 0xF)
> > +#define VREG_ADDR(addr)            (addr & ~0xF)
>
> It would be nice to add some #define FNAME GENMASK(x, y) accessed
> with FIELD_GET(FNAME, foobar), so that the code is a bit more
> self-explanatory
>
> Konrad

Thanks for the review.
Updates in v2 to use GENMASK() and FIELD_GET().

Thanks,
Maulik