[ Please remember to trim your replies and add a newline before your inline comments to make them readable. ] On Fri, Dec 29, 2023 at 02:06:26PM +0100, Konrad Dybcio wrote: > On 29.12.2023 14:01, Johan Hovold wrote: > > On Wed, Dec 27, 2023 at 11:28:27PM +0100, Konrad Dybcio wrote: > >> Fix the power-domains assignment to stop potentially toggling the GDSC > >> unnecessarily. > > > > Again, there's no additional toggling being done here, but yes, this may > > keep the domains enabled during suspend depending on how the driver is > > implemented. > No, it can actually happen. (Some) QMP PHYs are referenced by the > DP hardware. If USB is disabled (or suspended), the DP being active > will hold these GDSCs enabled. That's not a "toggling", is it? Also if the DP controller is a consumer of these PHY's why should it not prevent the PHYs from suspending? Johan
