On Wed, Dec 27, 2023 at 11:28:27PM +0100, Konrad Dybcio wrote:
> The USB GDSCs are only related to the controllers.
Are you sure?
> The PHYs on the other
> hand, are powered by VDD_MX and their specific VDDA_PHY/PLL regulators.
>
> Fix the power-domains assignment to stop potentially toggling the GDSC
> unnecessarily.
Again, there's no additional toggling being done here, but yes, this may
keep the domains enabled during suspend depending on how the driver is
implemented.
If that's the concern, then please spell that out too.
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
May not be needed either.
> @@ -2597,7 +2597,7 @@ usb_2_qmpphy0: phy@88ef000 {
> <&gcc GCC_USB3UNIPHY_PHY_MP0_BCR>;
> reset-names = "phy", "phy_phy";
>
> - power-domains = <&gcc USB30_MP_GDSC>;
> + power-domains = <&rpmhpd SC8280XP_MX>;
Johan
