On Wed, 13 Dec 2023 at 02:59, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote:
>
>
>
> On 12/12/2023 4:57 PM, Dmitry Baryshkov wrote:
> > Move CSC tables out of the header file to fix following kind of warnings:
> >
> > In file included from drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h:8,
> > from drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:5:
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h:54:33: warning: ‘dpu_csc10_rgb2yuv_601l’ defined but not used [-Wunused-const-variable=]
> > 54 | static const struct dpu_csc_cfg dpu_csc10_rgb2yuv_601l = {
> > | ^~~~~~~~~~~~~~~~~~~~~~
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h:39:33: warning: ‘dpu_csc10_YUV2RGB_601L’ defined but not used [-Wunused-const-variable=]
> > 39 | static const struct dpu_csc_cfg dpu_csc10_YUV2RGB_601L = {
> > | ^~~~~~~~~~~~~~~~~~~~~~
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h:24:33: warning: ‘dpu_csc_YUV2RGB_601L’ defined but not used [-Wunused-const-variable=]
> > 24 | static const struct dpu_csc_cfg dpu_csc_YUV2RGB_601L = {
> > | ^~~~~~~~~~~~~~~~~~~~
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c | 44 +++++++++++++++++++++
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 44 ++-------------------
> > 2 files changed, 47 insertions(+), 41 deletions(-)
> >
>
> Strange, I didnt hit this but change LGTM,
It shows with W=1, maybe that's why you didn't observe them.
>
> Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
--
With best wishes
Dmitry
