On 23-12-01 20:44:06, Manivannan Sadhasivam wrote:
> Currently, the function returns -EINVAL if algorithm other than AES-256-XTS
> is requested. But the correct error code is -EOPNOTSUPP. Fix it!
>
> Cc: Abel Vesa <abel.vesa@xxxxxxxxxx>
> Fixes: 56541c7c4468 ("scsi: ufs: ufs-qcom: Switch to the new ICE API")
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
LGTM.
Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> ---
> drivers/ufs/host/ufs-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index cbb6a696cd97..852179e456f2 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -158,7 +158,7 @@ static int ufs_qcom_ice_program_key(struct ufs_hba *hba,
> cap = hba->crypto_cap_array[cfg->crypto_cap_idx];
> if (cap.algorithm_id != UFS_CRYPTO_ALG_AES_XTS ||
> cap.key_size != UFS_CRYPTO_KEY_SIZE_256)
> - return -EINVAL;
> + return -EOPNOTSUPP;
>
> if (config_enable)
> return qcom_ice_program_key(host->ice,
> --
> 2.25.1
>
