On Wed, Nov 29, 2023 at 09:24:32AM +0000, Russell King (Oracle) wrote: > On Wed, Nov 29, 2023 at 03:12:07AM +0100, Christian Marangi wrote: > > Probe should be used only for DT parsing and allocate required priv, it > > shouldn't touch regs, there is config_init for that. > > I'm not sure where you get that idea from. PHY driver probe() functions > are permitted to access registers to do any setup that they wish to. > > config_init() is to configure the PHY for use with the network > interface. > > I think this patch is just noise rather than a cleanup. > I got it from here [1] Also on every other driver probe was always used for allocation and parsing so why deviates from this pattern here? Also I think it was wrong from the start as on reset I think WoL is not disabled again. (probe is not called) [1] https://elixir.bootlin.com/linux/latest/source/include/linux/phy.h#L916 -- Ansuel
