On Wed, Nov 29, 2023 at 03:12:07AM +0100, Christian Marangi wrote: > Probe should be used only for DT parsing and allocate required priv, it > shouldn't touch regs, there is config_init for that. I'm not sure where you get that idea from. PHY driver probe() functions are permitted to access registers to do any setup that they wish to. config_init() is to configure the PHY for use with the network interface. I think this patch is just noise rather than a cleanup. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!