On 03/11/2023 23:22, Dmitry Baryshkov wrote: > On Fri, 3 Nov 2023 at 20:49, Komal Bajaj <quic_kbajaj@xxxxxxxxxxx> wrote: >> >> Add qcm6490 devicetree file for QCM6490 IDP and QCM6490 RB3 >> platform. QCM6490 is derived from SC7280 meant for various >> form factor including IoT. >> >> Supported features are, as of now: >> * Debug UART >> * eMMC (only in IDP) >> * USB >> ... >> + >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-iot-common.dtsi b/arch/arm64/boot/dts/qcom/qcm6490-iot-common.dtsi >> new file mode 100644 >> index 000000000000..01adc97789d0 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-iot-common.dtsi > > I have mixed feelings towards this file. Usually we add such 'common' > files only for the phone platforms where most of the devices are > common. > Do you expect that IDP and RB3 will have a lot of common code other > than these regulator settings? I agree here. What exactly is common in the real hardware between IDP and RB3? Commit msg does not explain it, so I do not see enough justification for common file. Just because some DTS looks similar for different hardware does not mean you should creat common file. Best regards, Krzysztof
